Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(insight): added hosted insight version API #748

Merged
merged 7 commits into from
Oct 12, 2023
Merged

feat(insight): added hosted insight version API #748

merged 7 commits into from
Oct 12, 2023

Conversation

nathanlb
Copy link
Contributor

@nathanlb nathanlb commented Oct 5, 2023

Added the newly GA routes for hosted insight panel version history.
Updated the existing CRUD routes.

Acceptance Criteria

  • My changes are publicly available, documented, and deployed in production. (i.e. on Swagger)
  • JSDoc annotates each property added in the exported interfaces
  • The proposed changes are covered by unit tests
  • Commits containing breaking changes a properly identified as such
  • README.md is adjusted to reflect the proposed changes (if relevant)
  • My merge commit message will be conventional (See Conventional Commit)

@nathanlb nathanlb marked this pull request as ready for review October 5, 2023 18:57
@nathanlb nathanlb requested a review from a team October 5, 2023 18:57
@nathanlb nathanlb requested a review from a team as a code owner October 5, 2023 18:57
dmbrooke
dmbrooke approved these changes Oct 6, 2023
View reviewed changes
Copy link

@dmbrooke dmbrooke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is my first time reviewing anything from this project, but this all looks well written, documented, and unit tested, so I say :shipit:

GermainBergeron
GermainBergeron approved these changes Oct 11, 2023
View reviewed changes
Copy link
Member

@GermainBergeron GermainBergeron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good, but I could not find the call in swagger. Is it public yet?

lbergeron
lbergeron requested changes Oct 11, 2023
View reviewed changes
Copy link
Contributor

@lbergeron lbergeron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please validate versionNumber typing and missing body argument.

src/resources/InsightPanelInterfaces/InsightPanelInterface.ts Outdated Show resolved Hide resolved
src/resources/InsightPanelInterfaces/InsightPanelInterface.ts Outdated Show resolved Hide resolved
src/resources/InsightPanelInterfaces/tests/InsightPanelInterface.spec.ts Outdated Show resolved Hide resolved
@nathanlb nathanlb requested a review from lbergeron October 11, 2023 13:42
@nathanlb
Copy link
Contributor Author

Code looks good, but I could not find the call in swagger. Is it public yet?

@GermainBergeron they are public but not yet documented on Swagger. We'll do that shortly.

@nathanlb nathanlb merged commit 721351f into master Oct 12, 2023
4 checks passed
@nathanlb nathanlb deleted the feat/SVCC-3003 branch October 12, 2023 20:53
@github-actions
Copy link

🎉 This PR is included in version 48.2.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmbrooke dmbrooke dmbrooke approved these changes

@louis-bompart louis-bompart louis-bompart approved these changes

@lbergeron lbergeron lbergeron approved these changes

@GermainBergeron GermainBergeron GermainBergeron approved these changes

@FelixBlaisThon FelixBlaisThon Awaiting requested review from FelixBlaisThon

@btaillon-coveo btaillon-coveo Awaiting requested review from btaillon-coveo btaillon-coveo is a code owner automatically assigned from coveo/dx

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@nathanlb @GermainBergeron @lbergeron @louis-bompart @dmbrooke